Remove connection_timeout from Netmiko args

changelog/62547.fixed

@@ -0,0 +1 @@
+Remove the connection_timeout from netmiko_connection_args before netmiko_connection_args is added to __context__["netmiko_device"]["args"] which is passed along to the Netmiko library.

salt/proxy/netmiko_px.py

@@ -267,6 +267,7 @@ def init(opts):
     netmiko_connection_args.pop("proxytype", None)
     netmiko_connection_args.pop("multiprocessing", None)
     netmiko_connection_args.pop("skip_connect_on_init", None)
+    netmiko_connection_args.pop("connection_timeout", None)
 
     __context__["netmiko_device"]["args"] = netmiko_connection_args
 

tests/pytests/unit/proxy/test_netmiko_px.py

@@ -105,6 +105,24 @@ def test_init_skip_connect_on_init_false(proxy_minion_config):
     assert "connection" in netmiko_device
 
 
+def test_init_connection_timeout(proxy_minion_config):
+    """
+    check that connection_timeout is removed from args
+    before being passed along.
+    """
+
+    proxy_minion_config["connection_timeout"] = 60
+
+    mock_make_con = MagicMock()
+    with patch.object(netmiko_proxy, "make_con", mock_make_con):
+        assert netmiko_proxy.init(proxy_minion_config) is None
+
+    assert "netmiko_device" in netmiko_proxy.__context__
+    netmiko_device = netmiko_proxy.__context__["netmiko_device"]
+    assert "args" in netmiko_device
+    assert "connection_timeout" not in netmiko_device["args"]
+
+
 def test_make_con(proxy_minion_config):
     """
     check netmiko_proxy make_con method