[3006.x] Replace libnacl with PyNaCl #64389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
suggested changes
May 31, 2023
There was a problem hiding this comment.
This needs to be done in the salt-bootstrap repo, not on Salt's.
Please remove the change.
There was a problem hiding this comment.
Why is this file here and what is it doing then?
There was a problem hiding this comment.
Because that's what's used by salt-cloud to bootstrap VMs. We update this script whenever there are new releases of salt-bootstrap.
There was a problem hiding this comment.
Let's take the opportunity to migrate these tests to PyTest too.
|
Closing this in favor of #64415 which is the active PR for this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replacing libnacl with PyNaCl
What issues does this PR fix or reference?
Fixes: #64372 #64342
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.