Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix regression for user.present on handling groups with dupe GIDs #64431

Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #64430

Previous Behavior

Error in issue scenario.

New Behavior

Issue scenario now runs clean.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner June 6, 2023 20:20
@nicholasmhughes nicholasmhughes requested review from MKLeb and removed request for a team June 6, 2023 20:20
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix regression for user.present on handling groups with dupe GIDs [master] Fix regression for user.present on handling groups with dupe GIDs Jun 6, 2023
@nicholasmhughes nicholasmhughes changed the base branch from master to 3006.x June 6, 2023 20:26
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Fix regression for user.present on handling groups with dupe GIDs [3006.x] Fix regression for user.present on handling groups with dupe GIDs Jun 6, 2023
@nicholasmhughes nicholasmhughes force-pushed the fix-user.present-duplicate-groups branch from 5394d99 to 0dfced0 Compare June 6, 2023 20:26
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:10 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:10 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:11 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:11 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:28 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 6, 2023 22:33 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci June 7, 2023 01:39 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 2e4c57e into saltstack:3006.x Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] regression for user.present on handling groups with dupe GIDs
5 participants