Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM fix for MD tag generation with "b" FC. #1086

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

jkbonfield
Copy link
Contributor

We don't normally generate these features, using "B" instead. However some hand crafted CRAM files have shown we didn't create the correct MD tag due to forgetting to clear the distance since last edit, giving rise to the last numeric in MD being high.

Eg: MD:Z:0A98T0 came out as MD:Z:0A98T98 if that last T edit was a "b" feature.

0503_mapped.cram.zip

We don't normally generate these features, using "B" instead.  However
some hand crafted CRAM files have shown we didn't create the correct
MD tag due to forgetting to clear the distance since last edit, giving
rise to the last numeric in MD being high.

Eg: MD:Z:0A98T0 came out as MD:Z:0A98T98 if that last T edit was a "b"
feature.
jkbonfield added a commit to jkbonfield/io_lib that referenced this pull request Jun 19, 2020
See samtools/htslib#1086 for more details from
htslib PR.
@daviesrob daviesrob merged commit 313a9fc into samtools:develop Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants