-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to save logfiles seperate for each game #2504
Conversation
why not make it the default behavior instead of it being optional? |
I can do this when it is desired |
now that is an interesting idea indeed :) (the pr) |
@georgemoralis I agree, but what about a situation where some logs reach large sizes (like 100 MB) due to spam from a single team (cases like http in the Bloodborne log). Theoretically, you can have logs and even backup logs for each game, but this needs to be regulated somehow. We will either have to manually delete them if they are not needed, or we will need a mini-editor, something similar to what is on the Paths tab, to view all your logs. |
@GHU7924 I think we can create a certain number of backup files that will be compressed. Too old files should be deleted |
@Fire-Cube I mentioned another PR above. Two logs are created there, the previous one and the current one. I think that other PR is a good idea, and I think it can be useful for testing, where you can also compare the logs of two launches of the same game. With your PR, it will be easier for users to navigate magazines. Let's say you have 10 games and each one has been launched twice, which means you will have 20 logs. Deletion is already happening there, if I remember correctly, or overwriting. On a new start, the old log will be deleted, the second log will be renamed to the old one and a new one will also be created, which, as you understand, does not change the number of logs. To be honest, I don't know how to improve this moment yet. You were right to make it optional. |
@georgemoralis Could we merge this? I think the problem with backups should be worked on the other PR |
If I understand correctly, then to merge, you need to fix Clang and note that the PR is ready for review. |
i think it should be okay now |
clang error fixed now |
You can set up your fork to run the actions automatically, or alternatively you can run |
With this pull request, an option is added to the settings to save a separate log file for each game. For example as "CUSA19120.log". If not activated, everything stays as before. This can be very useful for debugging.