-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[style]: button for Github repo link. #428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Sakshi29G! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sakshi29G It looks nice but we can style more, like
font-family: 'Poppins';
border-radius: 15px;
cursor: pointer;
transition: all;
transition-duration: 500ms;
add above code to link_button
class and see the magic
Yeah, it is looking nice, but I think border radius should be 8px that makes it more similar to other boxes. |
src/components/Sidebar/Sidebar.css
Outdated
text-align: center; | ||
text-decoration: none; | ||
display: inline-block; | ||
font-size: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-size: 16px; | |
font-size: 14px; |
Change the font size to 14px,
16 is looking big.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@Sakshi29G Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further! |
Description
[Include a brief description of the changes you've made]
Related Issues
Issue #423
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist
Screenshots
Note to reviewers