Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style]: button for Github repo link. #428

Merged
merged 11 commits into from
Oct 4, 2023

Conversation

Sakshi29G
Copy link
Contributor

@Sakshi29G Sakshi29G commented Oct 2, 2023

Description

[Include a brief description of the changes you've made]

Related Issues

Issue #423

Changes Proposed

[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 5:29pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sakshi29G! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sakshi29G It looks nice but we can style more, like

font-family: 'Poppins';    
border-radius: 15px;    
cursor: pointer;    
transition: all;    
transition-duration: 500ms;

add above code to link_button class and see the magic

@Sakshi29G
Copy link
Contributor Author

Yeah, it is looking nice, but I think border radius should be 8px that makes it more similar to other boxes.

text-align: center;
text-decoration: none;
display: inline-block;
font-size: 16px;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: 16px;
font-size: 14px;

Change the font size to 14px,
16 is looking big.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@shyamtawli shyamtawli changed the title Button for github repo link. [style]: button for Github repo link. Oct 4, 2023
@shyamtawli shyamtawli merged commit bdf1023 into shyamtawli:master Oct 4, 2023
@shyamtawli
Copy link
Owner

@Sakshi29G Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants