WIP: Explore runSaga #777
Open
WIP: Explore runSaga #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edolix
force-pushed
the
eg/explore-run-saga
branch
from
6c7ba4c to
cb98064
Compare
edolix
force-pushed
the
eg/explore-run-saga
branch
from
cb98064 to
592e8cb
Compare
edolix
force-pushed
the
eg/explore-run-saga
branch
from
06dcd13 to
67429ed
Compare
edolix
force-pushed
the
eg/explore-run-saga
branch
from
9b26657 to
da62485
Compare
|
Rebased on |
edolix
commented
Apr 27, 2023
| while (true) { | ||
| /** | ||
| * Wait for an initAction to start | ||
| */ | ||
| const action = yield take([initAction.type, reauthAction.type]) | ||
| getLogger().info('RootSaga WAIT INIT') |
| logger.info('swStore >> Init Store?') | ||
| }, | ||
| start: (rootSaga: Saga, options: any) => { | ||
| logger.info('swStore >> Start') |
* EventEmitter for each instance of a component * remove branch from the main workflow * add changeset * add dev branch to workflow * add dev branch to ci/cd
* Calling worker to fork call workers * hanlde calling.call.state events * handle calling.call.dial event and move dial function to the client * fix answer() promise * handle calling.call.collect event * hanlde calling.call.send_digits event * handle calling.call.detect event * handle calling.call.tap event * handle calling.call.prompt event * handle calling.call.connect event * override on, once, and off functions for the Call * replace _on with on in e2e test cases * include changeset * fix playback event for prompt * fix call.detect event with internal sdk worker * unit test cases fix * rebased with the dev * replace overriden functions * fix instanceMap arg --------- Co-authored-by: edolix <[email protected]>
* Cleanup emitter transform for Voice Call APIs * include changeset
* Use base event emitter for Message API * emitter transform remove and changeset include * ApplyEventListeners comment update
* base emitter for chat and pubsub api * changeset included * improve pubsub and chat worker initializing * fix chat and pubsub e2e js case * improve chat and pubsub e2e js case * SDK child worker type fix * type issues fix for sub workers * more debug * more debug in voiceCallPlayWorker * update payload from voiceCallDialWorker * run only voice test for now * override event listeners for call instances * fix node script * fix voiceCallConnectWorker bug * fix test cases for playback and recording --------- Co-authored-by: edolix <[email protected]>
edolix
force-pushed
the
eg/explore-run-saga
branch
from
d2bd2d0 to
7b0b22d
Compare
iAmmar7
reviewed
May 5, 2023
| @@ -33,7 +33,7 @@ | |||
| "start:web": "sw-build --dev --web", | |||
| "start:node": "sw-build --dev --node --watchFormat=cjs", | |||
| "build": "tsc --project tsconfig.build.json && sw-build --web && sw-build --node", | |||
| "test": "NODE_ENV=test jest --detectOpenHandles --forceExit", | |||
| "test": "NODE_ENV=test jest", | |||
There was a problem hiding this comment.
Just trying to understand, why have we removed the --detectOpenHandles. Shouldn't we keep it to observe if Jest exits cleanly?
| dispatch(action: AnyAction) { | ||
| logger.info('swStore >> Dispatch', action) | ||
|
|
||
| // Process the action within reducers |
There was a problem hiding this comment.
Maybe we can add a TODO for future reference to move this logic to a reducer.
| init: () => { | ||
| logger.info('swStore >> Init Store?') | ||
| }, | ||
| start: (rootSaga: Saga, options: any) => { |
| @@ -124,17 +108,26 @@ const configureStore = (options: ConfigureStoreOptions) => { | |||
| remove: deleteInstance, | |||
| }, | |||
| }) | |||
|
|
|||
| // return sagaMiddleware.run(saga, { | |||
There was a problem hiding this comment.
Forgot to remove these comments related to the old middleware logic?
edolix
force-pushed
the
dev
branch
3 times, most recently
from
2703f14 to
bbe5b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.