Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return RoomSessionMember object instead of plain Member object in realtime-api #803

Merged
merged 3 commits into from
Jun 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-files-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@signalwire/realtime-api': patch
---

Return RoomSessionMember object instead of plain Member object
62 changes: 59 additions & 3 deletions packages/realtime-api/src/video/RoomSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ import {
Optional,
} from '@signalwire/core'
import { RealTimeRoomApiEvents } from '../types'
import { RoomSessionMember } from './RoomSessionMember'
import {
RoomSessionMember,
RoomSessionMemberEventParams,
createRoomSessionMemberObject,
} from './RoomSessionMember'

type EmitterTransformsEvents =
| InternalVideoRoomSessionEventNames
Expand All @@ -41,6 +45,15 @@ export interface RoomSession
ConsumerContract<RealTimeRoomApiEvents, RoomSessionFullState> {
baseEmitter: EventEmitter
setPayload(payload: Optional<VideoRoomEventParams, 'room'>): void
/**
* Returns a list of members currently in the room.
*
* @example
* ```typescript
* await room.getMembers()
* ```
*/
getMembers(): Promise<{ members: RoomSessionMember[] }>
}

export type RoomSessionUpdated = EntityUpdated<RoomSession>
Expand Down Expand Up @@ -199,15 +212,58 @@ export class RoomSessionConsumer extends BaseConsumer<RealTimeRoomApiEvents> {
protected setPayload(payload: Optional<VideoRoomEventParams, 'room'>) {
this._payload = payload
}

getMembers() {
return new Promise(async (resolve, reject) => {
try {
const { members } = await this.execute<
void,
{ members: RoomSessionMemberEventParams['member'][] }
>({
method: 'video.members.get',
params: {
room_session_id: this.roomSessionId,
},
})

const memberInstances: RoomSessionMember[] = []
members.forEach((member) => {
let memberInstance = this.instanceMap.get<RoomSessionMember>(
member.id
)
if (!memberInstance) {
memberInstance = createRoomSessionMemberObject({
store: this.store,
// @ts-expect-error
emitter: this.emitter,
payload: { member },
})
} else {
memberInstance.setPayload({
member,
} as RoomSessionMemberEventParams)
}
memberInstances.push(memberInstance)
this.instanceMap.set<RoomSessionMember>(
memberInstance.id,
memberInstance
)
})

resolve({ members: memberInstances })
} catch (error) {
reject(error)
}
})
}
}

export const RoomSessionAPI = extendComponent<
RoomSessionConsumer,
VideoRoomSessionMethods
Omit<VideoRoomSessionMethods, 'getMembers'>
>(RoomSessionConsumer, {
videoMute: Rooms.videoMuteMember,
videoUnmute: Rooms.videoUnmuteMember,
getMembers: Rooms.getMembers,
audioMute: Rooms.audioMuteMember,
audioUnmute: Rooms.audioUnmuteMember,
deaf: Rooms.deafMember,
Expand Down