-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
0b4e53e
to
49076dd
Compare
@@ -42,7 +42,7 @@ with the `Diff.ignore` instance. | |||
## collection support | |||
|
|||
Specify how objects within particular collection within particular diff instance should be matched. | |||
We distinguish free main types of collections: | |||
We distinguish three main types of collections: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, thanks for the great work. Let me fix the CI and then we will rebase your PR.
CI works again, please rebase your PR. |
Seems like we need to update scala3 version to 3.2.2 to have waver compile. |
|
Upgrade to scala 3.2.2.
@@ -96,7 +96,7 @@ lazy val core = (projectMatrix in file("core")) | |||
) | |||
.jvmPlatform( | |||
scalaVersions = List(scala212, scala213, scala3), | |||
settings = enableMimaSettings | |||
settings = enableMimaSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scalafmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should've added it as a CI check.
Released as 0.9.0, thanks again for the contribution! |
Thank you so much, I realise now I forgot to bump the versions matrix to 0.9.0 in weaver.md, due to the scala upgrade. |
Ah indeed, no worries I will fix that. Thanks for pointing it out. |
If you wonder why the documentation does not reflect your recent changes it is because there were some breaking changes in readthedocs and our documentation build is failing 🙃 |
@dabd fixed :) |
Add support for https://github.com/disneystreaming/weaver-test.