Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Add support for weaver-test #446

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

dabd
Copy link
Contributor

@dabd dabd commented Sep 19, 2023

@dabd dabd force-pushed the master branch 2 times, most recently from 0b4e53e to 49076dd Compare September 19, 2023 15:42
@@ -42,7 +42,7 @@ with the `Diff.ignore` instance.
## collection support

Specify how objects within particular collection within particular diff instance should be matched.
We distinguish free main types of collections:
We distinguish three main types of collections:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😅

Copy link
Collaborator

@ghostbuster91 ghostbuster91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks for the great work. Let me fix the CI and then we will rebase your PR.

@ghostbuster91
Copy link
Collaborator

CI works again, please rebase your PR.

@ghostbuster91
Copy link
Collaborator

Seems like we need to update scala3 version to 3.2.2 to have waver compile.

@dabd
Copy link
Contributor Author

dabd commented Sep 23, 2023

Seems like we need to update scala3 version to 3.2.2 to have waver compile.

Perhaps the scala3 upgrade should be done in another PR since the minor version bump might not be trivial, then I will rebase?
Trivial upgrade, just pushed.

Upgrade to scala 3.2.2.
@@ -96,7 +96,7 @@ lazy val core = (projectMatrix in file("core"))
)
.jvmPlatform(
scalaVersions = List(scala212, scala213, scala3),
settings = enableMimaSettings
settings = enableMimaSettings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scalafmt.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've added it as a CI check.

@ghostbuster91 ghostbuster91 merged commit 4612801 into softwaremill:master Sep 24, 2023
@ghostbuster91
Copy link
Collaborator

Released as 0.9.0, thanks again for the contribution!

@dabd
Copy link
Contributor Author

dabd commented Sep 24, 2023

Released as 0.9.0, thanks again for the contribution!

Thank you so much, I realise now I forgot to bump the versions matrix to 0.9.0 in weaver.md, due to the scala upgrade.

@ghostbuster91
Copy link
Collaborator

ghostbuster91 commented Sep 24, 2023

Ah indeed, no worries I will fix that. Thanks for pointing it out.

@ghostbuster91
Copy link
Collaborator

If you wonder why the documentation does not reflect your recent changes it is because there were some breaking changes in readthedocs and our documentation build is failing 🙃

@ghostbuster91
Copy link
Collaborator

@dabd fixed :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants