This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
stake-pool: Fund rent-exemption from reserve in decrease_additional
#5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
force-pushed
the
spdecaddl
branch
from
0359339 to
03dc2fe
Compare
2501babe
previously approved these changes
Sep 20, 2023
joncinque
force-pushed
the
spdecaddl
branch
from
55e3474 to
9c28d8f
Compare
mergify
bot
dismissed
2501babe’s stale review
Pull request has been modified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We should fund the rent-exempt reserve for the transient stake account from the stake pool reserve during decrease.
Solution
To start with, require the reserve during
decrease_additional_validator_stake, and then withdraw the rent-exemption from the reserve during processing.The next step after this is to create a new instruction for a normal decrease without an ephemeral stake account. Or we could deprecate the old one and force people to always use this one.