Improve performance of Yacht Dice #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also confirmed that the output is the exact same for the same seed. |
|
Oh, just for some benchmarks: Singleplayer is not improved by a ton, but still a bit: 5 player multiworld is improved a ton: |
NewSoupVi
commented
Jun 7, 2024
worlds/yachtdice/__init__.py
Outdated
| def collect(self, state: CollectionState, item: Item) -> bool: | ||
| change = super().collect(state, item) | ||
| if change and item.advancement: |
There was a problem hiding this comment.
The more specific you can be here about "which items does the state actually need to be recalculated on", the faster this will be
There was a problem hiding this comment.
...except for the exact way I did it, which is just slower lol, you already only get advancements in this function, so checking item.advancement is slower, my b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be improved further I'm sure. This is the maximally naive & pluggable & 5 minute solution
Working around the
state_is_listthing was quite annoying especially in this respect