-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: If a Qt binding is already imported, then use it. #139
Conversation
Looks good, some test failing though. Any chance we could write a test for this? |
Properly testing this looks slightly tricky as it appears that currently you have four CI setups each with just one of the dependencies installed, but to test this feature meaningfully you'd need another setup with two of them installed. We've been seeing failing tests (segfaulting) with the recently released pyqt5.10 on matplotlib as well and have downgraded the CI to use pyqt5.9. Do you know whether qtpy master passes with pyqt5.10? |
I agree. Since this change is quite minimal and easy to understand, I'm ok to not add a test for this one. Besides, Matplotlib is going to be the real test for this addition.
Ok, good to know. Let me pin pyqt to 5.9 here too, so our tests can pass @anntzer. |
@anntzer, please rebase against master to get the fix for our tests. |
done |
Thanks @anntzer for this. Being a dependency of Matplotlib is a huge achievement for a small project like this one! I'll try to release 1.4 as soon as possible (a couple of weeks at most). |
It's not a dependency yet but may become one soon... (matplotlib/matplotlib#6118) |
Yep, I know. |
@anntzer, qtpy 1.4 is out! |
thanks for the note :) |
Fixes #138.
See #138 for rationale.