Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: If a Qt binding is already imported, then use it. #139

Merged
merged 1 commit into from
Feb 13, 2018
Merged

PR: If a Qt binding is already imported, then use it. #139

merged 1 commit into from
Feb 13, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 13, 2018

Fixes #138.

See #138 for rationale.

@goanpeca
Copy link
Member

Looks good, some test failing though. Any chance we could write a test for this?

@anntzer
Copy link
Contributor Author

anntzer commented Feb 13, 2018

Properly testing this looks slightly tricky as it appears that currently you have four CI setups each with just one of the dependencies installed, but to test this feature meaningfully you'd need another setup with two of them installed.

We've been seeing failing tests (segfaulting) with the recently released pyqt5.10 on matplotlib as well and have downgraded the CI to use pyqt5.9. Do you know whether qtpy master passes with pyqt5.10?

@ccordoba12 ccordoba12 added this to the v1.4 milestone Feb 13, 2018
@ccordoba12 ccordoba12 changed the title If a qt binding is already imported, then use it. PR: If a Qt binding is already imported, then use it. Feb 13, 2018
@ccordoba12
Copy link
Member

Properly testing this looks slightly tricky

I agree. Since this change is quite minimal and easy to understand, I'm ok to not add a test for this one. Besides, Matplotlib is going to be the real test for this addition.

@goanpeca?

We've been seeing failing tests (segfaulting) with the recently released pyqt5.10 on matplotlib as well and have downgraded the CI to use pyqt5.9

Ok, good to know. Let me pin pyqt to 5.9 here too, so our tests can pass @anntzer.

@ccordoba12
Copy link
Member

@anntzer, please rebase against master to get the fix for our tests.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 13, 2018

done

@ccordoba12
Copy link
Member

Thanks @anntzer for this. Being a dependency of Matplotlib is a huge achievement for a small project like this one!

I'll try to release 1.4 as soon as possible (a couple of weeks at most).

@ccordoba12 ccordoba12 merged commit 9e5324f into spyder-ide:master Feb 13, 2018
@anntzer anntzer deleted the usealreadyimported branch February 13, 2018 22:41
@anntzer
Copy link
Contributor Author

anntzer commented Feb 13, 2018

It's not a dependency yet but may become one soon... (matplotlib/matplotlib#6118)

@ccordoba12
Copy link
Member

Yep, I know.

@ccordoba12
Copy link
Member

@anntzer, qtpy 1.4 is out!

@anntzer
Copy link
Contributor Author

anntzer commented Mar 11, 2018

thanks for the note :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants