Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some proposed improvements to the file switcher #10682

Closed
jnsebgosselin opened this issue Nov 12, 2019 · 3 comments · Fixed by #10698
Closed

Some proposed improvements to the file switcher #10682

jnsebgosselin opened this issue Nov 12, 2019 · 3 comments · Fixed by #10698
Assignees
Milestone

Comments

@jnsebgosselin
Copy link
Member

1. Make items sorted in ascending order

I think it would make more sense to sort the filtered items in ascending order instead of descending order in the switcher.

image

2. Make the list view looks like is has the focus.

The focus is given to the line edit of the switcher, while the focus policy of the list view is set to NoFocus. This is not a big deal, but this make the selected item in the list looks like it is not active (while in reality, it is implemented in such a way that it has the functionality of an active list view, i.e. navigation with the arrows, selection with enter, etc).

So, I think the switcher should look like it has the focus and is active as a whole. I suggest that we trick the html delegate that is used in the list view into thinking that it is active at all times, even if strictly speaking it is not.

image

Versions

  • Spyder 4.0.0.dev0 (Commit: a74824d)
  • Python 3.7.3 64-bit | Qt 5.9.6 | PyQt5 5.9.2 | Windows 10
@goanpeca
Copy link
Member

I think it would make more sense to sort the filtered items in ascending order instead of descending order in the switcher.

That is probably a regression from moving to the new switcher. 👍

So, I think the switcher should look like it has the focus and is active as a whole. I suggest that we trick the html delegate that is used in the list view into thinking that it is active at all times, even if strictly speaking it is not.

Sounds good too !

Could you open a PR @jnsebgosselin ?

@jnsebgosselin
Copy link
Member Author

Could you open a PR @jnsebgosselin ?

Yes, I'm already working on this 👍

@ccordoba12 ccordoba12 added this to the v4.0.0 milestone Nov 12, 2019
@jnsebgosselin jnsebgosselin self-assigned this Nov 12, 2019
@ccordoba12
Copy link
Member

I agree with both suggestions. Thanks @jnsebgosselin for helping us with them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants