Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make the list view of the file switcher look active at all times. #10683

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Nov 12, 2019

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Trick the html delegate that is used in the list view of the file switcher into thinking that it is active at all times, even if strictly speaking it is not.

See #10682 for more details.

image

Issue(s) Resolved

Fixes item number 2 in #10682

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jean-Sébastien Gosselin

@goanpeca
Copy link
Member

@jnsebgosselin could you add an issue on Qdarkstyle to add a difference between active and not active items?

@jnsebgosselin
Copy link
Member Author

jnsebgosselin commented Nov 12, 2019

@jnsebgosselin could you add an issue on Qdarkstyle to add a difference between active and not active items?

sure, I will do it.

Edit: The aforementioned qdarkstyle issue can be found at ColinDuquesnoy/QDarkStyleSheet#209

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac, works as expected

@ccordoba12 ccordoba12 added this to the v4.0.0 milestone Nov 12, 2019
@ccordoba12 ccordoba12 merged commit 8181f8d into spyder-ide:master Nov 12, 2019
@jnsebgosselin jnsebgosselin deleted the fix_switcher_focus_style branch November 13, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants