[FORMATTING] tsql: odbc keywords and datatypes as column identifiers are incorrectly formatted

[rmja]

Input data

Which SQL and options did you provide as input?

SELECT Name, Value, 123 as Timestamp FROM Zone zone;

with the following options

const prettierPluginSqlConfig = {
    language: "tsql",
    keywordCase: "upper",
    functionCase: "upper",
    dataTypeCase: "lower",
};

Expected Output

SELECT
    Name,
    Value,
    123 AS Timestamp
FROM
    Zone zone;

Actual Output

SELECT
    Name,
    VALUE,
    123 AS timestamp
FROM
    ZONE ZONE;

Note the incorrect casing of VALUE, timestamp, and ZONE.

Usage

• How are you calling / using the library? prettier-plugin-sql
• What SQL language(s) does this apply to? tsql
• Which SQL Formatter version are you using? master branch

[nene]

Thanks for reporting.

Looks like there are way too many keywords listed for tsql, a lot of which aren't actual reserved keywords. Cleaning up this list to only leave the actual reserved keywords (as documented in here) should take care of the problem with VALUE and ZONE.

However with TIMESTAMP, which is also a name of a data type, SQL Formatter is unable to distinguish when it's being used as a data type and when it's being used as plain identifier.

[nene]

I close this, as I fixed the problem with ODBC keywords (by just throwing them all away), but the problem with TIMESTAMP really can't be fixed within the current architecture of SQL Formatter . My suggestion is simply to not use the dataTypeCase: "lower" option.

[rmja]

Thank you! Year, I guess I can use AS [Timestamp] as a workaround.