chore: trade apk size to speed up launch time #22156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen-ghafouri
approved these changes
Feb 18, 2025
briansztamfater
approved these changes
Feb 18, 2025
|
Hey @siddarthkay ! Thaks for this PR, I'm wondering, what was the previous bundle size and what is the new one? |
|
There is an 
|
|
Nice finding @siddarthkay! The 400ms improvement can vary a lot per app it seems. This number comes from the Discord app from the linked RN PR right? If so, before merging this PR I think it's important we show evidence of sufficient improvement to justify the increase in bundle size. Let's say in 2-3 Android devices sufficiently different and averaging the test runs. For this, it seems that a QA won't be able to test this PR because we need precise measurements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR un compresses the android bundle which apparently improves Time to Interactivity by 400ms.
There is a slight tradeoff in bundle size and I want to measure that.
This technique was first discovered and accepted by RN team here : facebook/react-native#49449
Platforms
status: ready