fix: Add assets cleanup target when calling dotnet clean, clarify ref out of sync issues #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out of sync issues
Kryptos-FR
reviewed
Feb 5, 2025
| namespace Stride.Core.Serialization; | ||
|
|
||
| public class ContentRefOutOfSyncException() | ||
| : InvalidOperationException("Serialization contentRef indices are out of sync, assets need to be rebuilt, clean your projects and rebuild"); |
There was a problem hiding this comment.
Note for later: there are ways to localize exception messages. We should decide whether we want to do it, or not. It can be painful sometimes when errors are localized (in term of discovery), but it could also help users of languages we already support.
sources/assets/Stride.Core.Assets.CompilerApp/build/Stride.Core.Assets.CompilerApp.targets
Show resolved
Hide resolved
Jklawreszuk
reviewed
Feb 6, 2025
| @@ -160,6 +160,11 @@ | |||
| </Target> | |||
|
|
|||
| <!-- Clean assets --> | |||
| <Target Name="StrideCleanAssetsOnClean" AfterTargets="Clean"> | |||
There was a problem hiding this comment.
nit: Prehabs simply "StrideCleanAssets" ?
There was a problem hiding this comment.
That was what I went with initially but there's already a target named StrideCleanAsset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Content out of sync exception triggers when removing/adding a property to a custom asset, this change ensures users are aware of how to proceed when encountering this issue.
Types of changes
Checklist
Kindly pinging @Jklawreszuk to check this one as he is more experienced with the build system than I am