-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the logic of current interval number #3561
Conversation
That output looks good to me. I'm recommend @walterbender to review the code. |
Could you please add NOTESTEP to the list of constants exported in musicutils.js ? |
added notestep in musicutils.js |
Looks good. But question for @pikurasa : right now, this block is "hidden". I presume we can expose it as an advanced block? |
"Interval number" block is hidden? |
Yes. Hidden on the palette by default... |
Then, yes, we should expose it in our advanced mode. |
@walterbender just curious advance block means that block does not appear in the left menu bar . we only access the block by searching ? And every thing seems to be fine so can u merge this . |
The block was marked as "hidden" since it was not working as Devin had wanted. Now that it is working, it should not be hidden so it appears in the palette. Advanced vs Beginner is a separate flag. But this should be advanced, not beginner. |
Got it . Should I make changes for beginnerblock to advance block and hidden to false ? |
Yes. And you can just delete the hidden line since false is the default. |
did the changes |
issue #2209
block is working in the interval block and notes blocks . tried in the examples given in the issue .
after
current.interval.mp4