[-Wunsafe-buffer-usage] Accept calls to some libc functions with annotated arguments #10088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tated arguments - `printf`, `fprintf` `snprintf` functions accept `__null_terminated` - `snprintf` function accepts `__counted_by/__sized_by` - functions consuming a single string pointer like `strlen` or `atoi` accept `__null_terminated` Generalized `isCountAttributedPointerArgumentSafe` so that it is shared by interoperation gadgets and the unsafe libc gadget. (A follow-up change to rdar://138798346)
|
CC @dtarditi |
|
This PR depends on #10060 |
ziqingluo-90
commented
Feb 21, 2025
| @@ -747,7 +747,7 @@ const Expr *extractExtentFromSubviewDataCall(ASTContext &Context, | |||
| static bool hasIntegeralConstant(const Expr *E, uint64_t Val, ASTContext &Ctx) { | |||
| Expr::EvalResult ER; | |||
|
|
|||
| if (E->EvaluateAsConstantExpr(ER, Ctx)) { | |||
| if (E->EvaluateAsInt(ER, Ctx)) { | |||
There was a problem hiding this comment.
According to https://github.com/llvm/llvm-project/pull/124022/files, the result of EvaluateAsConstantExpr may not necessarily be able to getInt() later.
ziqingluo-90
commented
Feb 21, 2025
| @@ -23,7 +23,7 @@ namespace std { | |||
| T* p; | |||
| T *c_str(); | |||
| T *data(); | |||
| unsigned size_bytes(); | |||
There was a problem hiding this comment.
A mistake I made in the test---std::string has no size_bytes method.
ziqingluo-90
commented
Feb 22, 2025
| @@ -366,6 +366,7 @@ isInUnspecifiedUntypedContext(internal::Matcher<Stmt> InnerMatcher) { | |||
|
|
|||
| namespace { | |||
|
|
|||
| /* TO_UPSTREAM(BoundsSafetyInterop) ON */ | |||
There was a problem hiding this comment.
I assume there is no problem in upstreaming the part of the interop in UnsafeBufferUsage.cpp? @patrykstefanski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printf,fprintfsnprintffunctions accept__null_terminatedsnprintffunction accepts__counted_by/__sized_bystrlenoratoiaccept__null_terminatedGeneralized
isCountAttributedPointerArgumentSafeso that it is shared by interoperation gadgets and the unsafe libc gadget.(A follow-up change to rdar://138798346)