-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxVisible
option for select prompts
#225
Conversation
Reviewer note: after making this change, I realized that the I think before merging this I'd like to:
|
Looks really good @elliot-nelson! Could be nice to have this as a part of the next release. I agree we should try to have a consistent API 👍 |
Updated preview image to show changes to |
I was looking at this for Since it's not merged yet. I have a version that does the same for autocomplete using your helper-methods. One concern with mine is that it removes the pages in |
@bbernstein that looks great! Personally, I think the pagination in the autocomplete should go away completely and just be scrolling, as then the experience for select, multi select, autocomplete, and autocompleMultiselect can all be the same. (I like your "smooth" experience more than the pagination.) |
Thank you so much @elliot-nelson and @bbernstein. I agree, I think we should use this across all prompts instead of pagination. This provides a better user experience for sure. I appreciate the help. Can we choose/merge this and #227. I'm a bit busy this week, but I'll have some time to merge and release the next version over the weekend |
I'll cancel what I had done earlier (at the same time as @elliot-nelson) and have made changes that will be based on this PR. Once this one is merged, I'll add my changes for a separate PR. |
@bbernstein this is now merged into master |
SUMMARY
Allow the "select" prompt to display a subset of the options at a time.
DETAILS
Changes to
select
optionsPerPage
option added, similar tomultiselect
optionsPerPage
now defaults to 10, which is a change in behavior if you had select lists with more than 10 elements. (I think this change is a net positive, but it probably requires at least a minor version bump.)Changes to
multiselect
Test changes
entriesToDisplay
).PREVIEW