Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed save & restore #5

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Fixed save & restore #5

merged 2 commits into from
Jul 4, 2019

Conversation

elie-g
Copy link
Contributor

@elie-g elie-g commented Jul 4, 2019

I did the following in the same order:

  1. I changed the name of the constant containing the CSI (ESC) to the appropriate name (CSI).
  2. Created a new constant named ESC containing only the ANSI escape character.
  3. Fixed save & restore by using the ESC constant instead of CSI
  4. Added tests for save & restore
  5. Ran the tests (69/69 passed)

NOTE:
I noticed that both constants clear and beep in index.js are exactly the same. Is this intended?
Both of them are exported.

clear & beep

@elie-g
Copy link
Contributor Author

elie-g commented Jul 4, 2019

I check the ASCII table and the 7th character (\u0007) is the bell so idk if clear is used anywhere but I really doubt it clears anything.

ASCII Table

@terkelg
Copy link
Owner

terkelg commented Jul 4, 2019

Maybe I meant clearScreen as here: https://github.com/sindresorhus/ansi-escapes/blob/master/index.js#L83. But I think it's safe to remove for now

@terkelg terkelg merged commit e6df154 into terkelg:master Jul 4, 2019
@elie-g elie-g deleted the save-restore branch September 18, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants