-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): enable Signature Scheme v3 #13938
Conversation
Moving to |
Think we should be fine
and
source: https://source.android.com/docs/security/features/apksigning So adding v3 will still fall back to v2 or v1 if needed |
This looks good to me, but I haven't tested it. I believe we can set both |
The only issue with v4 was that Google is not listing it the same way:
They don't mention v4 in there, only at the subsection https://source.android.com/docs/security/features/apksigning/v4 v3 was requested by a user for security reasons and Google says it will automatically fall back to v1 and v2 so I only tested that so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Approving though I didn't test it. Merge when ready.
https://source.android.com/docs/security/features/apksigning/v3
Test
[path to sdk]/build-tools/33.0.1/apksigner verify --verbose output.apk
and check forVerified using v3 scheme (APK Signature Scheme v3): true
Note
I have no knowledge about the Signature Schemes and if we lose support for Android < 9 with this. It says it's the same block format as v2 so it might still work. Just putting this out there if needed and someone has more infos about it.