-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networking support #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l containers Co-Authored-By: Jose Soto <[email protected]> Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Not sure why WIndows is erroring but it has nothing to do with this code. |
41094f1
to
be69ec5
Compare
be69ec5
to
8b27136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networking Todo:
takeout
networkTO--mailhog--v1.0.1
) in the target Docker-based Laravel appsmysql
--aliasmysql
easily, but people with multiple MySQL containers also have something usablemysql80
)mysql
)@test
on themBrainstorm on the naming situation:
Every container gets tagged with
mysql80
:@josecanhelp gave his blessing to Option 1 🙌
Option 1:
mysql80
) and the first instance of that type that I spin up also gets the short version (mysql
), with the intention of later making it so we can allow them to repoint the shortcutOption 2:
mysql
) to the latest of those I have openEvery container doesn't necessarily get tagged with the version:
Option 3:
Option 4: (not prefered)
Option 5: (not prefered)
mysql1
,mysql2
,etc