Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): notification system #10053

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 10, 2025

No description provided.

Copy link
Member Author

fengmk2 commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 60.90323% with 303 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (5748591) to head (e6262b2).

Files with missing lines Patch % Lines
packages/backend/server/src/models/notification.ts 57.39% 95 Missing ⚠️
...backend/server/src/__tests__/utils/notification.ts 14.89% 80 Missing ⚠️
...es/backend/server/src/core/notification/service.ts 34.73% 62 Missing ⚠️
...s/backend/server/src/core/notification/resolver.ts 50.81% 29 Missing and 1 partial ⚠️
...ages/backend/server/src/core/notification/types.ts 92.30% 13 Missing ⚠️
...ckages/backend/server/src/base/error/errors.gen.ts 79.48% 8 Missing ⚠️
...ages/backend/server/src/base/graphql/pagination.ts 58.33% 5 Missing ⚠️
packages/backend/server/src/models/user.ts 37.50% 5 Missing ⚠️
...ckages/backend/server/src/core/notification/job.ts 78.57% 2 Missing and 1 partial ⚠️
.../backend/server/src/__tests__/utils/testing-app.ts 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10053      +/-   ##
==========================================
- Coverage   54.04%   52.65%   -1.40%     
==========================================
  Files        2327     2334       +7     
  Lines      107089   107853     +764     
  Branches    17747    17540     -207     
==========================================
- Hits        57875    56786    -1089     
- Misses      47888    49745    +1857     
+ Partials     1326     1322       -4     
Flag Coverage Δ
server-test 73.89% <60.64%> (-4.40%) ⬇️
unittest 31.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 force-pushed the 02-10-feat_server_notification branch from 980f4f4 to e01dd25 Compare February 14, 2025 12:52
@github-actions github-actions bot added the test Related to test cases label Feb 14, 2025
@fengmk2 fengmk2 force-pushed the 02-10-feat_server_notification branch 2 times, most recently from 1da9b64 to bc2b61a Compare February 14, 2025 15:45
@fengmk2 fengmk2 changed the title feat(server): notification feat(server): notification system Feb 14, 2025
@fengmk2 fengmk2 force-pushed the 02-10-feat_server_notification branch 2 times, most recently from a8b30f2 to 72750d8 Compare February 17, 2025 05:37
@fengmk2 fengmk2 force-pushed the 02-10-feat_server_notification branch from 72750d8 to e6262b2 Compare February 17, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant