Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): turbo renderer stale frame lag on zooming #10376

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from

Conversation

doodlewind
Copy link
Member

@doodlewind doodlewind commented Feb 23, 2025

Before:

Screen.Recording.2025-02-23.at.10.20.31.PM.mov

After:

Screen.Recording.2025-02-23.at.10.22.19.PM.mov

This is only a bug fix that ensures correct baseline rendering result. There'll be more optimizations specific for zooming TBD.

Copy link
Member Author

doodlewind commented Feb 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.23%. Comparing base (9fd1ca1) to head (a074bae).

Files with missing lines Patch % Lines
.../shared/src/viewport-renderer/viewport-renderer.ts 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10376   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files        2327     2327           
  Lines      108096   108093    -3     
  Branches    17843    17844    +1     
=======================================
- Hits        58624    58623    -1     
+ Misses      48143    48132   -11     
- Partials     1329     1338    +9     
Flag Coverage Δ
server-test 78.70% <ø> (+<0.01%) ⬆️
unittest 31.24% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doodlewind doodlewind changed the title refactor(editor): remove force refresh debug fix(editor): turbo renderer stale frame lag on zooming Feb 23, 2025
@doodlewind doodlewind marked this pull request as ready for review February 23, 2025 14:28
@doodlewind doodlewind requested a review from a team as a code owner February 23, 2025 14:28
@graphite-app graphite-app bot requested review from a team February 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant