Solution to #109 #110
Solution to #109 #110
Conversation
FunFunFine
requested review from
danslapman,
eld0727,
Odomontois and
Z1kkurat
as code owners
| type HasContext[F[_], C] = Context[F] { type Ctx = C } | ||
| type HasLocal[F[_], C] = Local[F] { type Ctx = C } | ||
| type HasContext[F[_], C] = Context[F] { type Ctx = C } | ||
| object HasContext { |
There was a problem hiding this comment.
I fill those belong to Errors.scala
There was a problem hiding this comment.
@Odomontois Why do you think summoning instances belongs to Errors file?
There was a problem hiding this comment.
package objects are nasty things in terms of refactoring, bytecode, binary compatibility
I'd like to have them as small as possible, so all the things, that are defineable in the package itself, should be defined in the package itself, I feel
update from master;
|
finally moved summoners to Errors.scala as @Odomontois said |
|
@FunFunFine can you please format the files? Seems like our modern formatter doesn't quite like current formatting: https://travis-ci.com/TinkoffCreditSystems/tofu/jobs/282971940#L269 |
|
LGTM. @Odomontois if you don't have any objections I will merge this |
Made it possible to summon implicit instances from context