fix ZLogs #115
Merged
fix ZLogs #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
road21
requested review from
danslapman,
eld0727,
Odomontois and
Z1kkurat
as code owners
Odomontois
reviewed
Jan 16, 2020
| } | ||
| } | ||
|
|
||
| val ZLogs: ZLogsOps.type = ZLogsOps |
There was a problem hiding this comment.
That is unusual encoding, what does that fix?
Also why do we define package object logging in the module that doesn't own package logging
What if we decide to define package object logging in the logging core?
Would it be more wise define those in the tofu.logging.zio package?
There was a problem hiding this comment.
I just wanted to keep structure tofu.logging.ZLogs, but I totally agree that it will be much better to make separate tofu.logging.zio. Otherwise if we decide to define package object in core it will be unaccessible.
Fixed.
Odomontois
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unusable trait
ZLogs