Add convenient syntax for working with F[Either[E, A]] #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssstlis
requested review from
danslapman,
eld0727,
Odomontois and
Z1kkurat
as code owners
road21
reviewed
Feb 25, 2020
| F.lift(e) | ||
| } | ||
|
|
||
| def mergeF(implicit ev: L =:= R, F: Functor[F]): F[R] = { |
There was a problem hiding this comment.
def mergeF[A >: R](implicit ev: L <:< A, F: Functor[F]): F[A]?
| F.flatMap(productF(eb))(_.traverse { case (r, r1) => f(r, r1) }) | ||
| } | ||
|
|
||
| def mapK[G[_]](implicit F: ~>[F, G]): G[Either[L, R]] = { |
There was a problem hiding this comment.
I don't think that's a good idea to make natural transformation implicit.
Do we really need mapK and liftTo methods here?
There was a problem hiding this comment.
At the last minute i became doubted about it but decided to left it. So, if it doesn't looks good enough i can cut it.
| F.flatMap(e) { | ||
| case Right(right) => f(right) | ||
| case left @ Left(_) => F.pure(left.rightCast) | ||
| } |
There was a problem hiding this comment.
I think we can keep just one method from doubleFlatMap, flatMapF
Odomontois
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve #149
I had some questions about documentation in source file and do i need to use helpers in tests or not?