Lift/IsoK smart constructors #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GusevTimofey
requested review from
catostrophe,
danslapman,
Odomontois and
Z1kkurat
as code owners
catostrophe
requested changes
Aug 10, 2020
catostrophe
requested changes
Aug 10, 2020
| @@ -30,4 +30,11 @@ object IsoK { | |||
| def to[A](fa: F[A]): F[A] = fa | |||
| def from[A](ga: F[A]): F[A] = ga | |||
| } | |||
|
|
|||
| def byFunK[F[_], G[_]](fg: F ~> G, gf: G ~> F): IsoK[F, G] = | |||
There was a problem hiding this comment.
I would like to have (fg: F ~> G)(gf: G ~> F) to make it consistent with methods from tofu.syntax.lift._
catostrophe
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.