Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summon objects for Scoped aliases #422

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Add summon objects for Scoped aliases #422

merged 3 commits into from
Oct 22, 2020

Conversation

catostrophe
Copy link
Member

closes #401

@catostrophe
Copy link
Member Author

Also added one missing summoner

@Odomontois Odomontois merged commit ddcd623 into tofu-tf:master Oct 22, 2020
@Tvaroh
Copy link
Contributor

Tvaroh commented Oct 22, 2020 •
edited
Loading

Isn't tofu.syntax.scoped.deferFuture supposed to match ScopedExecute.deferFuture signature? Atm it matches ScopedExecute.deferFutureAction. Perhaps should have syntax for both?

@catostrophe catostrophe deleted the scoped-summoners branch October 23, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odomontois Odomontois Odomontois approved these changes

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

@Z1kkurat Z1kkurat Awaiting requested review from Z1kkurat

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Execute[F].deferFuture work as before
3 participants
@catostrophe @Tvaroh @Odomontois