Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Logging documentation #483

Merged
merged 10 commits into from
Feb 10, 2021
Merged

Improve Logging documentation #483

merged 10 commits into from
Feb 10, 2021

Conversation

FunFunFine
Copy link
Member

@FunFunFine FunFunFine commented Dec 29, 2020 •
edited
Loading

Closes #471

  • add documentation on creation of logging
  • annotations (@hidden, etc.)
  • presence of derevo integration
  • ELKLayout description with usage in context of logback.xml
  • more detailed description of contextual logging - explanation for leveraging slf4j marker APIs for passing context values (including usage in ELKLayout)
  • more complex examples of initializing logging classes and passing them as dependencies to other components (with multiple effects)
  • add examples
  • tofu.logging.LoggingCompanion
  • LoggingCompanion caveat and fixes for it

@FunFunFine
reorder blocks;
1d236f0 
add documentation on creation of logging;
add examples;
@FunFunFine FunFunFine changed the title Improve Logging documentation Draft: Improve Logging documentation Dec 29, 2020
@FunFunFine FunFunFine changed the title Draft: Improve Logging documentation Improve Logging documentation Dec 29, 2020
@FunFunFine
Copy link
Member Author

@oskin1 @catostrophe pls review
(stole this one from #489 🙈 )

@Odomontois Odomontois merged commit d4e6b1f into tofu-tf:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odomontois Odomontois Odomontois approved these changes

@catostrophe catostrophe Awaiting requested review from catostrophe catostrophe is a code owner

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

@Z1kkurat Z1kkurat Awaiting requested review from Z1kkurat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Logging documentation
2 participants
@FunFunFine @Odomontois