Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation for logging #731

Merged
merged 25 commits into from
Sep 11, 2021
Merged

Better documentation for logging #731

merged 25 commits into from
Sep 11, 2021

Conversation

FunFunFine
Copy link
Member

@FunFunFine FunFunFine commented Jul 29, 2021 •
edited
Loading

  • LoggingBase is deprecated due to plans on simplifying Logging's hierarchy.
  • Logs.Universal is deprecated in favour of Logging.Make to match the cats-effect-3 style and simplify all of that.

Custom Logs recipe has to be written by someOne eLsE who's Got the corresponding expirience.

catostrophe
catostrophe reviewed Jul 29, 2021
View reviewed changes
@FunFunFine FunFunFine changed the title DRAFT: better documentation for logging Better documentation for logging Aug 20, 2021
patseev
patseev reviewed Aug 20, 2021
View reviewed changes
Copy link

@patseev patseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to hint that everything works out of box with ZIO as well

@FunFunFine
Copy link
Member Author

Would be cool to hint that everything works out of box with ZIO as well

Sadly, I don't have that much experience with ZIO to write myself a full example for that. I will add a hint to check out the ZLogs module anyway.

@FunFunFine
fmt;
4518b0a 
fixes from review;
hint for ZIO;
auto logs example;
example links;
@FunFunFine
more to examples readme;
5dececc
@FunFunFine
more to examples readme;
8d05b80 
fix unembed
@FunFunFine
fmt;
4376947
@FunFunFine
Merge remote-tracking branch 'origin/master' into logging-raspilize
8d67478 
# Conflicts:
#	project/Dependencies.scala
@FunFunFine
fmt;
790ac19
@catostrophe catostrophe self-requested a review September 11, 2021 09:12
@catostrophe catostrophe merged commit 4ce26a8 into master Sep 11, 2021
@mergify mergify bot deleted the logging-raspilize branch September 11, 2021 09:13
@catostrophe catostrophe added the enhancement New feature or request label Sep 11, 2021
@FunFunFine FunFunFine mentioned this pull request Sep 12, 2021
Merged
@gzoom13 gzoom13 mentioned this pull request Oct 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehakun mehakun mehakun left review comments

@patseev patseev patseev left review comments

@catostrophe catostrophe catostrophe approved these changes

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@Odomontois Odomontois Awaiting requested review from Odomontois Odomontois is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FunFunFine @mehakun @patseev @catostrophe