Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELKLayout read static json from customFields tag #766

Merged
merged 2 commits into from
Sep 17, 2021
Merged

ELKLayout read static json from customFields tag #766

merged 2 commits into from
Sep 17, 2021

Conversation

Phill101
Copy link
Contributor

No description provided.

@Odomontois
Copy link
Member

That's great, but a small docstring above def setCustomFields about usage would be cool

@Phill101 Phill101 force-pushed the layout-custom-fields branch from 80b092d to 8235f55 Compare September 17, 2021 08:17
@Phill101 Phill101 force-pushed the layout-custom-fields branch from 8235f55 to c1e98b2 Compare September 17, 2021 08:27
@Odomontois Odomontois merged commit 5dc5fd0 into tofu-tf:master Sep 17, 2021
@Phill101 Phill101 deleted the layout-custom-fields branch September 17, 2021 09:41
@Odomontois Odomontois added the enhancement New feature or request label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odomontois Odomontois Odomontois approved these changes

@catostrophe catostrophe Awaiting requested review from catostrophe catostrophe is a code owner

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@FunFunFine FunFunFine Awaiting requested review from FunFunFine FunFunFine is a code owner

@oskin1 oskin1 Awaiting requested review from oskin1 oskin1 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phill101 @Odomontois