Implicit conversion from Bind to cats.Monad #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From user perspective, when I require Bind instance in my code, I want to have implicit cats.Monad instance for later usages. Now to do so I have to write something like implicit def monad[E] = bind.monad[E] in the beginning of the method, since most of the library methods accept typeclasses as implicit parameters. Assuming that Bind is right-biased, it makes perfect sense to write such implicit conversion and use it in source file imports section.
gzoom13
requested review from
catostrophe,
danslapman,
FunFunFine,
Odomontois and
oskin1
as code owners
Ssstlis
reviewed
Oct 3, 2021
modules/higherKindCore/src/test/scala/tofu/control/CatsInstancesFromBindSuite.scala
Outdated
Show resolved
Hide resolved
Ssstlis
reviewed
Oct 3, 2021
modules/higherKindCore/src/test/scala/tofu/control/CatsInstancesFromBindSuite.scala
Outdated
Show resolved
Hide resolved
Odomontois
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From user perspective, when I require Bind instance in my code,
I want to have implicit cats.Monad instance for later usages. Now to do so
I have to write something like implicit def monad[E] = bind.monad[E]
in the beginning of the method, since most of the library methods accept
typeclasses as implicit parameters.
Assuming that Bind is right-biased, it makes perfect sense to write such
implicit conversion and use it in source file imports section.