New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and Refactor Benchmark Code #7170

Open

NeoByteXx wants to merge 2 commits into tokio-rs:master from NeoByteXx:master

+2 −2

NeoByteXx commented Feb 23, 2025

for _ in 0..(NUM_WORKERS) { → for _ in 0..NUM_WORKERS {
Improves readability and follows Rust conventions.

Fix loop condition in Spinner (signal_benchmark.rs)

if self.count > 3 { → if self.count >= 3 {
Ensures correct iteration count.

NeoByteXx added 2 commits

February 23, 2025 22:14


          Update rt_multi_threaded.rs

2285ea8


          Update signal.rs

9a235cd

maminrayej added the A-benches label

Member

maminrayej commented Feb 24, 2025

if self.count > 3 { → if self.count >= 3 {
Ensures correct iteration count.

I don't understand why the previous iteration count was wrong and what this change fixes. Could you explain the motivation behind this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels