Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add last_executed_pc property to abstract CPU #2475

Merged
merged 5 commits into from
Sep 10, 2021
Merged

Add last_executed_pc property to abstract CPU #2475

merged 5 commits into from
Sep 10, 2021

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Aug 2, 2021

Helpful for knowing the exact last executed instruction address.

@ekilmer ekilmer mentioned this pull request Aug 2, 2021
Draft
@ekilmer ekilmer marked this pull request as ready for review August 24, 2021 20:53
@ekilmer ekilmer requested a review from ehennenfent August 24, 2021 21:04
ehennenfent
ehennenfent suggested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this passes the sanity check assuming I've understood what you're trying to do correctly. To that end, a couple of comments explaining why last_executed_pc might not always match last_pc would be helpful.

@ekilmer
Add last_executed_pc property to abstract CPU
88cb3a3 
Helpful for knowing the exact last executed instruction address.
@ekilmer
Fix some types
4b1df58
@ekilmer
Set last_executed_pc to insn.address when disagreement on PC and insn
9e63b0d 
This should be correct since some hook has intercepted the events for
the instruction and "executed" it for us.
@ekilmer
Simplify instruction publish event call
dad3121
@ekilmer
Add more documentation for last executed pc/instruction
b85f657
@ekilmer ekilmer requested a review from ehennenfent September 9, 2021 15:37
@ekilmer ekilmer merged commit 7c905c8 into master Sep 10, 2021
@ekilmer ekilmer deleted the last_executed_pc branch September 10, 2021 18:03
ekilmer added a commit that referenced this pull request Sep 15, 2021
@ekilmer
Merge branch 'master' into chess
4156aef 
* master:
  Add methods for getting list of (un)implemented system calls (#2491)
  Unpin Truffle Version, Use Latest crytic-compile (#2490)
  Add last_executed_pc property to abstract CPU (#2475)
ekilmer added a commit that referenced this pull request Oct 30, 2021
@ekilmer
Merge branch 'master' into capstone-5-dev
ee2433c 
* master:
  Add methods for getting list of (un)implemented system calls (#2491)
  Unpin Truffle Version, Use Latest crytic-compile (#2490)
  Add last_executed_pc property to abstract CPU (#2475)
  Bump Node from 13.x to 16.x (#2484)
  Copy/Snapshot a RegisterFile (#2489)
  Add more logging messages around solver errors (#2485)
  Add manticore reference property to States (#2486)
  Option to kill Manticore if any state fails on unrecoverable error (#2487)
  Optionally publish events for memory reads (#2488)
  Install Python3.7 in Docker image (#2482)
  Prioritize LD_LIBRARY_PATH over system default path (#2476)
  track parent in state descriptors (#2479)
  Switch to Python 3.7 (#2472)
  Fix loading custom interpreters for ELF binaries (#2473)
  Create CITATION.cff
@ehennenfent ehennenfent mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehennenfent ehennenfent ehennenfent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekilmer @ehennenfent