Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for release v0.0.14 and add fix for ruff #234

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Prep for release v0.0.14 and add fix for ruff #234

merged 3 commits into from
Mar 30, 2023

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Mar 30, 2023 •
edited
Loading

Several fixes:

  1. Bump required_trunk_version to >=1.7.0
  2. Bump test version to 1.7.0
  3. Fix a couple of snapshots by trimming their messages. This improves testing success rate, particularly for trivy
  4. Remove the key bucket from snapshots (removed in trunk version 1.7.0). Note that this will break LUV/release tests until v0.0.14 is released.
  5. Add a fix to the ruff parser to accommodate its newest release. Still passes old snapshots (it's backwards compatible).

Tested the parser with lots of diagnostics in the flask and pylint repos.

@TylerJang27 TylerJang27 marked this pull request as ready for review March 30, 2023 01:08
@TylerJang27 TylerJang27 requested a review from det March 30, 2023 01:08
@TylerJang27 TylerJang27 merged commit 7561ce7 into main Mar 30, 2023
@TylerJang27 TylerJang27 deleted the tyler/bump-to-170 branch March 30, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@det det det approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJang27 @det