Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain alphabetical order in linters/plugin.yaml #513

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

andreilgeorgescu
Copy link
Contributor

Fixes #512

@trunk-io
Copy link

trunk-io bot commented Oct 8, 2023

✨ This comment will be updated with CI stats as CI jobs run ✨
settingsfeedbackdocs ⋅ learn more about trunk.io

@EliSchleifer
Copy link
Member

/trunk skip-check

@TylerJang27
Copy link
Collaborator

Thanks for the PR! We really should have a formatter that does this, but I'm not aware of any good YAML-sorting formatters that also respect comments.

A couple notes:

  • Feel free to add the haskell filetypes as you mentioned
  • Disregard Trunk Check failing on this PR. We are investigating an issue with Trunk Check running on forks
  • I just retriggered the tests. They pass for me locally, but if anything seems off I'll follow up

@TylerJang27
Copy link
Collaborator

Looks like the only failure is sourcery not having the right tokens for forks. I'll look into skipping sourcery for forked-PRs. In the meantime I can manually merge this when it's ready.

@TylerJang27 TylerJang27 merged commit 6573d6f into trunk-io:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Maintain alphabetical order in linters/plugin.yaml
3 participants