Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore *.dockerignore files as they do not conform to the Dockerfile spec #943

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

NellyWhads
Copy link
Contributor

Docker supports ignore files to keep build contexts clean.

The current configuration ignores the generic .dockerignore as expected, but attempts to lint Dockerfile-specific configurations such as Dockerfile.dockerignore, test.Dockerfile.dockerignore and Dockerfile.build.dockerignore.

This PR aims to resolve this bug.

Copy link

trunk-io bot commented Dec 27, 2024

⏱️ 43m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 21m 🟩
Linter Tests macOS 19m 🟩
Trunk Check runner [linux] 1m 🟩
CodeQL-Build 1m 🟩
Repo Tests / Plugin Tests 31s 🟩
Detect changed files 5s 🟩
Aggregate Test Results 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks again!

@TylerJang27 TylerJang27 merged commit b2fa5ce into trunk-io:main Dec 30, 2024
13 checks passed
@NellyWhads NellyWhads deleted the dockerignore branch December 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants