-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds terraform-docs action ⚡ #966
feat: adds terraform-docs action ⚡ #966
Conversation
⏱️ 11m total CI duration on this PR
|
91434ff
to
a37c8e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for your patience through all this!
Unfortunately we don't yet support referencing tools in Trunk Actions, only package tools. This is a known shortcoming atm. The best you can do is something similar to the commitzen definition, and optionally in your script:
- Check for the presence of
.trunk/tools/terraform-docs
or.trunk/tools/terraform-docs.ps1
- If present, evaluate it directly
- If
terraform-docs
is in the PATH, use that - Otherwise call
trunk tools install terraform-docs
I'll leave it up to you if you want to add that to your script, this is good to land with or without that change.
6.
Gotcha. For now... let's Thanks for the help moving this forward @TylerJang27! |
Sounds great. I'm going to try and get an official release out soon, but in the meantime you can always set the |
## Info * Follow up from #966 - Executing `python` doesn't do the trick, the executable needs to be `python3`
Info
terraform-docs
? I only see atools
declaration forcommitizen
and I'm unsure if I can enforce that the user is using tools/terraform-docs. What am I missing there?