feat(settings): review custom domain #10393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce improved validation logic for custom domains, including regex validation with descriptive error messages. Implement asynchronous domain update functionality with a loading indicator and polling to check record statuses. Refactor components to streamline functionality and align with updated state management.
Removed leftover console debug statement in the workspace service file. This ensures cleaner logs and avoids unintended output in production environments.
Removed a redundant null check for records in custom-domain.service. The check was unnecessary as the code already ensures valid records are processed.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances custom domain management with improved validation, status handling, and user feedback mechanisms across both frontend and backend components.
- Added comprehensive regex validation in
SettingsDomain.tsxrequiring subdomains and preventing invalid characters with descriptive error messages - Implemented 10-second delay before CNAME verification in
custom-domain.service.tsto prevent false negatives during DNS propagation - Added loading states and polling mechanism in
SettingsCustomDomainEffect.tsxfor real-time domain validation status updates - Enhanced error handling with specific error codes and rollback mechanisms for domain operations in workspace service
- Introduced debounced clipboard functionality in
SettingsCustomDomainRecords.tsxfor better UX when copying domain records
10 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/pages/settings/workspace/SettingsCustomDomainEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/SettingsCustomDomainEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/SettingsCustomDomainRecordsStatus.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/SettingsCustomDomainRecordsStatus.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/SettingsCustomDomainRecordsStatus.tsx
Outdated
Show resolved
Hide resolved
Simplified the map functions in SettingsCustomDomainRecords and SettingsCustomDomainRecordsStatus by removing unnecessary return statements and braces. This improves readability and aligns with cleaner coding practices.
Moved records array definition outside the component for better readability and performance. Simplified table row mapping by directly iterating through rows array.
Improve custom domain status display with styling updates and added capitalized text. Introduce loading indicators and adjust polling interval for better feedback. Implement additional UI enhancements such as padding adjustments and consistency across components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce improved validation logic for custom domains, including regex validation with descriptive error messages. Implement asynchronous domain update functionality with a loading indicator and polling to check record statuses. Refactor components to streamline functionality and align with updated state management.
Fix twentyhq/core-team-issues#453