ci/stitchmd: Support updating PRs from forks #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operation failed in #174 because the PR was made from a fork. Looking at the [documentation for git-auto-commit-acton](https://github.com/stefanzweifel/git-auto-commit-action), it's possible to support this for forks as well if we use the `pull_request_target` event (which runs in the context of the base branch), and check out the PR repository (which may be a fork). See also https://github.com/stefanzweifel/git-auto-commit-action#workflow-should-run-in-base-repository for details.
mway
approved these changes
May 9, 2023
abhinav
added a commit
that referenced
this pull request
May 9, 2023
#181 tried to fix support for PRs from forks by changing the event to pull_request_target. However, it did not update the check we do on github.event_name later to decide whether we're in check mode or write. This updates the job to fix the event name match.
abhinav
added a commit
that referenced
this pull request
May 9, 2023
#181 tried to fix support for PRs from forks by changing the event to pull_request_target. However, it did not update the check we do on github.event_name later to decide whether we're in check mode or write. This updates the job to fix the event name match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation failed in #174 because the PR was made from a fork. Looking at the documentation for git-auto-commit-acton, it's possible to support this for forks as well if we use the
pull_request_targetevent (which runs in the context of the base branch), and check out the PR repository (which may be a fork). See also https://github.com/stefanzweifel/git-auto-commit-action#use-in-forks-from-public-repositories.