Last cleanups from CR

uber-go · Feb 21, 2017 · 1e69a29 · 1e69a29
1 parent 3ba540d
commit 1e69a29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/global.go b/global.go
@@ -59,8 +59,6 @@ func S() *SugaredLogger {
 //
 // It's safe for concurrent use.
 func ReplaceGlobals(logger *Logger) func() {
-	// This doesn't require synchronization to be safe, since pointers are a
-	// single word.
 	_globalMu.Lock()
 	prev := _globalL
 	_globalL = logger

diff --git a/global_test.go b/global_test.go
@@ -26,13 +26,13 @@ import (
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/atomic"
-
 	"go.uber.org/zap/internal/observer"
 	"go.uber.org/zap/testutils"
 	"go.uber.org/zap/zapcore"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"go.uber.org/atomic"
 )
 
 func TestReplaceGlobals(t *testing.T) {