Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder does not support to_sql #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Builder does not support to_sql #1

wants to merge 4 commits into from

Conversation

tyronewilson
Copy link

@tyronewilson tyronewilson commented Aug 11, 2016 •
edited
Loading

  1. This gem was not compatible with influxdb gem since they inflect as 'InfluxDB' and this gem does 'Influxdb' This was causing undefined constant InfluxDB::Client as soon as this gem is installed to take care of the query syntax. I have renamed the files and constants in the gem to match those in the official influxdb ruby client. Now they can load side by side.
  2. I found Builder does not support to_sql but rather if you do builder.select.to_sql it works per the README.md

@tyronewilson
Builder does not support to_sql
d64c705 
I found Builder does not support to_sql but rather if you do builder.select.to_sql it works per the README.md
@tyronewilson
Change the top level namespace to be InfluxDB to match influxdb-ruby …
ff47636 
…otherwise the gems conflict in rails with autoloading
@tyronewilson
More updates to ensure the gem retains it's name but we have the righ…
37419ef 
…t mix of constants
@tyronewilson
Copy link
Author

I don't know why the Travis CI tests have failed but I ran rspec in my local env and all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tyronewilson