unify dataframe definitions to fix auto-complete #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having two different dataframes defined under an `if` is for some reason causing PyCharm to not offer auto-complete of DataFrame methods/attributes. I'm not entirely sure why but some trial and error showed that this refactor seems to produce the correct behaviour
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 99.36% 99.32% -0.04%
==========================================
Files 22 22
Lines 2663 2666 +3
==========================================
+ Hits 2646 2648 +2
- Misses 17 18 +1
Continue to review full report at Codecov.
|
|
thanks @admackin! I'm not a pycharm user myself, so this is a super helpful fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having two different dataframes defined under an
iffor some reason causing PyCharm to not offer auto-complete ofDataFrame methods/attributes. I'm not entirely sure why but some trial and error showed that this refactor seems to produce the correct behaviour. Note that I was sometimes able to get auto-complete working without this change, but it seemed to reliably work with the change added.
Before
After