Window Support Fix--Update pyproject.toml #1748
Open
+21
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes & Improvements: I Removed Duplicate [build-system] Sections: The [build-system] section was defined multiple times, which could cause conflicts. Ensure Triton is Available for Windows: Triton doesn't officially support Windows. So i included prebuilt wheels from woct0rdho/triton-windows Also ensured Windows-Specific bitsandbytes Handling
|
Why are there deletions of dependencies? |
|
I made changes to the pyproject.toml file to ensure compatibility across
both Windows and Linux environments. Specifically, I handled the
platform-specific dependencies to ensure that the right versions of
libraries are installed depending on the system. For Windows, I’ve ensured
that bitsandbytes-windows and a Windows-compatible version of triton are
included, as these are specifically tailored for Windows. For Linux, the
original bitsandbytes and triton versions are used.
I will Check again to ensure the deleted Dependencies are added Back sorry
for the mistake.
…On Tue, Feb 18, 2025 at 12:24 PM Daniel Han ***@***.***> wrote:
Why are there deletions of dependencies?
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL3YYMRDBD7ADMPLMDTD2QMJ7TAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGM3TANBVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: danielhanchen]*danielhanchen* left a comment
(unslothai/unsloth#1748)
<#1748 (comment)>
Why are there deletions of dependencies?
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL3YYMRDBD7ADMPLMDTD2QMJ7TAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGM3TANBVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Fixed!
Yes they were and they were duly referenced check my read me. Ai gave me a
start point and I refined some steps . Hence the issue.
…On Fri, 21 Feb 2025 at 08:05, Kareem ***@***.***> wrote:
Why are there deletions of dependencies?
All of the PRs created by this person are AI generated
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL36VEWBUR4F75V5V3LL2Q3F43AVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZTG42TCMBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: KareemMusleh]*KareemMusleh* left a comment
(unslothai/unsloth#1748)
<#1748 (comment)>
Why are there deletions of dependencies?
All of the PRs created by this person are AI generated
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL36VEWBUR4F75V5V3LL2Q3F43AVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZTG42TCMBVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Apologies this is incorrect sorry! |
|
No problem, thanks!,I have rectified it also… I made a fix in which bits
and bytes and all other pip install function tools worked…but triton still
don’t work in a window space except using WSL2 should I commit that?
…On Mon, 24 Feb 2025 at 00:30, Daniel Han ***@***.***> wrote:
Apologies this is incorrect sorry!
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL34BEMKW2FFGYRZULGL2RJK2XAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGE4DANBYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: danielhanchen]*danielhanchen* left a comment
(unslothai/unsloth#1748)
<#1748 (comment)>
Apologies this is incorrect sorry!
—
Reply to this email directly, view it on GitHub
<#1748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7URL34BEMKW2FFGYRZULGL2RJK2XAVCNFSM6AAAAABXLIJFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGE4DANBYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes & Improvements:
I Removed Duplicate [build-system] Sections: The [build-system] section was defined multiple times, which could cause conflicts.
Ensure Triton is Available for Windows: Triton doesn't officially support Windows. So i included prebuilt wheels from woct0rdho/triton-windows
Also ensured Windows-Specific bitsandbytes Handling