Remove BelowSubsistenceThreshold and NewContractNotFunded
#1062
Conversation
There was a problem hiding this comment.
Return codes didn't change for backwards compatibility. We merely stopped emitting some of them. Please check: https://github.com/paritytech/substrate/blob/450cd6804dd77312b27d72ebdebccc4c6027f579/frame/contracts/src/wasm/runtime.rs#L47-L77
|
@athei Argh, ofc, I've updated the PR. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri Dec 3 09:49:50 CET 2021 |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
===========================================
- Coverage 78.79% 63.22% -15.57%
===========================================
Files 248 248
Lines 9371 9369 -2
===========================================
- Hits 7384 5924 -1460
- Misses 1987 3445 +1458
Continue to review full report at Codecov.
|
HCastano
added
the
E-on-ice
examples/contract-transfer/lib.rs
Outdated
| /// - Panics in case the requested transfer would have brought the | ||
| /// contract balance below the subsistence threshold. | ||
| /// - Panics in case the requested transfer would have brought this | ||
| /// contract's balance below the minimum balance. |
There was a problem hiding this comment.
What balance is the minimum balance referring to in this case?
There was a problem hiding this comment.
The chains existential deposit, I clarified it in the comment.
…k#1062) * Remove `BelowSubsistenceThreshold` and `NewContractNotFunded` * Fix `clippy:single-match` * Fix doc-link * Fix `clippy:redundant-pattern-matching` * Fix error codes * Fix error codes * Remove superfluous whitespace * Clarity what minimum balance refers to * Fix typo: chain's ➜ chains * Revert "Fix typo: chain's ➜ chains" This reverts commit 40c0920.
Do not merge yet!
Closes #1044.
Follow-up to paritytech/substrate#10082.
I haven't adapted the off-chain testing environment for the deposit mechanism, I'll create a follow-up for that. Right now, the off-chain env doesn't take the new deposit mechanism into account in any way.