Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize is_contract and caller_is_origin #1166

Merged
merged 1 commit into from
Mar 4, 2022
Merged

stabilize is_contract and caller_is_origin #1166

merged 1 commit into from
Mar 4, 2022

Conversation

agryaznov
Copy link
Contributor

Follow-up to substrate#10971

@agryaznov
Copy link
Contributor Author

I'm currently getting e2e test for this failing (using updated contracts node):

RUST_LOG=info cargo test --features polkadot-js-ui -- contract_introspection

results in error:

thread 'tests::contract_introspection::delegator_works' panicked at 'upload must have succeeded, but events contain only [Event { header: "", status: "balances.Withdraw" }]', src/uis/polkadot_js.rs:417:9

seems like it fails even to upload the contract

Not sure exactly what the problem is.

@codecov-commenter
Copy link

Codecov Report

Merging #1166 (0fa5c46) into master (2da20ea) will decrease coverage by 17.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1166       +/-   ##
===========================================
- Coverage   78.43%   61.16%   -17.27%     
===========================================
  Files         231      230        -1     
  Lines        8760     8730       -30     
===========================================
- Hits         6871     5340     -1531     
- Misses       1889     3390     +1501     
Impacted Files Coverage Δ
crates/lang/codegen/src/traits.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/env.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/enforced_error.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/blake2b.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/storage.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/arg_list.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/selector.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da20ea...0fa5c46. Read the comment docs.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

⚠️ The ink! master is ahead of your branch, this might skew the comparison data below.

These are the results when building the examples/* contracts from this branch with cargo-contract 0.17.0-536caf5 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.28 K
adder 2.23 K
contract-introspection -0.01 K 2.61 K
contract-terminate 1.23 K 214_418
contract-transfer 8.37 K 14_418
delegator 6.24 K 46_504
dns 9.62 K 43_254
erc1155 27.49 K 86_508
erc20 9.09 K 43_254
erc721 14.37 K 115_344
flipper 1.55 K 14_418
incrementer 1.49 K 14_418
multisig 26.12 K 94_107
proxy 3.22 K 29_563
rand-extension 4.38 K 14_418
subber 2.24 K
trait-erc20 9.36 K 43_254
trait-flipper 1.33 K 14_418
trait-incrementer 1.42 K 28_836

Link to the run | Last update: Fri Mar 4 17:37:48 CET 2022

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmichi cmichi merged commit 3122bad into master Mar 4, 2022
@cmichi cmichi deleted the stabilizator branch March 4, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants