feat: improvements and testing for RLP ink! contracts #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwht
commented
Jan 24, 2025
| let selector = keccak_selector(b"flip"); | ||
| let callee: AccountId = callee.into(); | ||
|
|
||
| // TODO: fails due to call builder encoding with scale |
There was a problem hiding this comment.
more accurately, issue is coming from here:
…ion for tests to build
…ts and unused imports
This reverts commit 01e4f46.
peterwht
changed the title
cmichi
reviewed
Feb 12, 2025
|
|
||
| #![cfg_attr(not(feature = "std"), no_std, no_main)] | ||
|
|
||
| #[ink::contract(abi_encoding = "rlp")] |
There was a problem hiding this comment.
Suggested change
| #[ink::contract(abi_encoding = "rlp")] | |
| #[ink::contract(abi_encoding = "rlp")] |
Is it only encoding or also decoding?
There was a problem hiding this comment.
It's both encoding and decoding. Do you have a recommendation? Can address in the solidity ABI PR as I have to rename from rlp anyway.
There was a problem hiding this comment.
We should also support something like abi = "all".
peterwht
commented
Feb 15, 2025
| )) | ||
| } | ||
|
|
||
| if encoding.is_rlp() && !(encoding.is_all() && message.user_provided_selector().is_some()) { |
There was a problem hiding this comment.
just a temporary fix for compilation. Added TODO in #2401
cmichi
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements and fixes for RLP encoded ink! contracts.
Includes compile tests, as well as e2e tests for: