Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More idiomatic return types for metadata getters #2398

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Feb 10, 2025

Summary

Closes - N/A

  • [y] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

More idiomatic return types for some metadata getters that return references to types that are cheap to copy.

Description

Changes a few metadata getter assoc fns that return &T when T: Copy to return T instead

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@cmichi cmichi merged commit 39157b3 into use-ink:master Feb 11, 2025
@davidsemakula davidsemakula deleted the metadata-copy-return-types branch February 11, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants